Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update cookie to match original spec #1847

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Conversation

devfreddy
Copy link
Contributor

Description

The original spec for the cookie was generic and not specific to NRIO or Quickstarts. We need to move towards the generic approach to move in line with architectural guidance, remove special cases in repositories, and improve analytics.

This is the first of multiple steps to move us towards that generic cookie start_target.

I'm going to go step-wise:

  1. Update here
  2. Update in guided-install's router which reads the cookie and sends you to the appropriate location
  3. Return here and remove newrelic-quickstart-id unless it's being used elsewhere

Reviewer Notes

Reviewer should only need verify writing the cookie succeeds

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

If relevant, add screenshots here.

Use Conventional Commits

Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.

Use chore

  • for minor changes / additions / corrections to content.
  • for minor changes / additions / corrections to images.
  • for minor non-functional changes / additions to github actions, github templates, package or config updates, etc
git commit -m "chore: adjusting config and content"

Use fix

  • for minor functional corrections to code.
git commit -m "fix: typo and prop error in the code of conduct"

Use feat

  • for major functional changes or additions to code.
git commit -m "feat(media): creating a video landing page"

@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 4, 2021

Gatsby Cloud Build Report

developer-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 2m

Performance

Lighthouse report

Metric Score
Performance 🔶 29
Accessibility 💚 90
Best Practices 💚 93
SEO 🔶 76

🔗 View full report

@devfreddy devfreddy requested a review from aswanson-nr November 5, 2021 16:41
@jpvajda
Copy link
Contributor

jpvajda commented Nov 16, 2021

just following up on this PR as I saw it sitting ready to merge. It looks like:

this code is going to set two cookies so it’s okay to merge and then someone will come back and delete the one they don’t need

confirmed from @LizBaker

@jpvajda jpvajda merged commit 1092c0c into develop Nov 16, 2021
@jpvajda jpvajda deleted the mfrederick/update-cookie branch November 16, 2021 22:36
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.69.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants