fix: Update cookie to match original spec #1847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original spec for the cookie was generic and not specific to NRIO or Quickstarts. We need to move towards the generic approach to move in line with architectural guidance, remove special cases in repositories, and improve analytics.
This is the first of multiple steps to move us towards that generic cookie
start_target
.I'm going to go step-wise:
newrelic-quickstart-id
unless it's being used elsewhereReviewer Notes
Reviewer should only need verify writing the cookie succeeds
Related Issue(s) / Ticket(s)
If there are any related GitHub Issues or JIRA tickets, add links to them here.
Screenshot(s)
If relevant, add screenshots here.
Use Conventional Commits
Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.
Use
chore
git commit -m "chore: adjusting config and content"
Use
fix
git commit -m "fix: typo and prop error in the code of conduct"
Use
feat
git commit -m "feat(media): creating a video landing page"