-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lucia/update nerdpack detail docs #1748
Merged
Merged
Changes from 13 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
ecc177f
chore: add screenshot of what's inside tab
brammerl 68b7ce9
chore: fix spacing
brammerl 460100a
chore: update whats-inside-nerdlet-tab image
brammerl dcdc841
chore: add screenshots to 'Describe your app for catalog'
brammerl 3e7b9d9
chore: fix image sourcing
brammerl 1a29eac
chore: update implementing feedback given
brammerl 4f651f0
fixing spacing
brammerl ef1dd47
updating photo reference and photo
brammerl 7e34724
chore: remove image reference
brammerl 6ea8c89
chore: remove image
brammerl a376e04
chore: add screenshots to create world app page
brammerl e80e3e8
chore: fix sourcing and image style
brammerl 3937bd5
chore: dimage reference updates
brammerl a19bb2a
Update src/markdown-pages/build-apps/serve-publish-subscribe/catalog.mdx
brammerl 2e25878
chore: remove unused images
brammerl 56e76d3
chore: replace whats inside image
brammerl 329466b
chore: rephrase step 3/5 in add details to describe your project
brammerl d2dc3d3
chore: changing verbiage within describe your app for the catalog
brammerl 4943a6e
Update build-hello-world-app.mdx
brammerl 30e0d8e
Update build-hello-world-app.mdx
brammerl 0ca1ac7
Update src/markdown-pages/build-apps/serve-publish-subscribe/catalog.mdx
brammerl 724639d
chore: add screenshot to ab-test publish documentation
brammerl efcfcb0
chore: italicize directory reference
brammerl 6b1541f
chore: add descriptive text between images
brammerl 928016d
chore: add text between images in publish section for ab-test
brammerl e116bee
chore: small language fix
mehreentahir16 a23d06e
chore: updated screenshot
mehreentahir16 56bbf18
Merge branch 'develop' into lucia/update-nerdpack-detail-docs
brammerl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this seems like a good guide place to mention Nerdpack-item level screenshots
2 suggestions:
What's inside
tab would actually be empty if they clicked itHow we change it to something like:
Note that the above suggestion also updates the title and link at the end of step 3, since it seemed to be outdated.
What's inside
tab, hasApps
as its root breadcrumb. For consistency here, and especially since step 5 indicates explicitly that we're coming from I/O, could you replace this screenshot with one whereInstant Observability (I/O)
is the root breadcrumb?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, when there are two screenshots in a row, I like to add some text between them for a transition and for visual relief. Could we maybe add:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brammerl would you mind addressing my comment here, as well? I think the second screenshot here could really benefit from its own description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexronquillo done!