Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlosier/io packdetails refresh #1709

Merged
merged 19 commits into from
Sep 29, 2021
Merged

Conversation

MichelLosier
Copy link
Contributor

@MichelLosier MichelLosier commented Sep 28, 2021

Description

Updates guide content and images to the new I/O experience for the following articles:

  • Create a "Hello, World!" application
  • Serve, publish, and subscribe to your Nerdpack
    • Publish your Nerdpack
    • Update your Nerdpack's catalog information
    • Serve your Nerdpack
    • Subscribe to a Nerdpack
  • Customize open-source Nerdpacks
  • Attach your nerdlet to your entities
  • Customize your visualization with configuration options
  • Add your custom visualization to a dashboard
  • a-b test course
    • Serve your New Relic One application
    • Publish your New Relic One application
    • Subscribe to your New Relic One application

Reviewer Notes

If there are links or steps needed to test this work, add them here.

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

If relevant, add screenshots here.

Use Conventional Commits

Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.

Use chore

  • for minor changes / additions / corrections to content.
  • for minor changes / additions / corrections to images.
  • for minor non-functional changes / additions to github actions, github templates, package or config updates, etc
git commit -m "chore: adjusting config and content"

Use fix

  • for minor functional corrections to code.
git commit -m "fix: typo and prop error in the code of conduct"

Use feat

  • for major functional changes or additions to code.
git commit -m "feat(media): creating a video landing page"

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 28, 2021

Gatsby Cloud Build Report

developer-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 🔶 26
Accessibility 💚 90
Best Practices 💚 93
SEO 🔶 76

🔗 View full report

@jpvajda
Copy link
Contributor

jpvajda commented Sep 28, 2021

I reviewed these changes but will defer to the dev ad team for final review and approval. Thanks for the submission

jaesius
jaesius previously approved these changes Sep 29, 2021
Copy link
Contributor

@jaesius jaesius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting all of these changes and refreshing the screenshots

@alexronquillo
Copy link
Contributor

Thanks, I'll take a look at these changes this morning!

mehreentahir16
mehreentahir16 previously approved these changes Sep 29, 2021
Copy link
Contributor

@alexronquillo alexronquillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MichelLosier! Thanks for the updates. I think that the changes you've made are great, and I really appreciate the attention to detail with the screenshots. Using a similar aspect ratio to the existing images really helps!

Most of my comments refer not to what you changed, but what you didn't change. It seems like we're moving away from references to the New Relic One catalog because all published Nerdpacks are in Instant Observability now. If that's the case, I think there are a few more changes to make because there are a lot of remaining references to "New Relic One catalog" or just "catalog" across the repo. Would you mind fixing those with this PR, as well?

One more thing is the video in "Create a "Hello, World!" application" is now outdated with these changes. Could you remove that video? I'm going to create a ticket for us to get a new video, but with the introduction of I/O, we think it's just better to remove it for now.

Thanks! Please feel free to push back or clarify something if my understanding is wrong here.


![Navigate to Apps](../../../images/build-an-app/nav-to-apps.png)
![Navigate to Instant Observability](../../../images/serve-publish-subscribe/nav-to-io.png)

From here, you can see your application under **New Relic One catalog**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a missed reference to the old New Relic One catalog. I'm not sure of the official terminology here, but based on the UI ("Showing 429 resources"), maybe this could read:

From here, you can see your application among the Instant Observability resources:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the next paragraph seems outdated:

Notice that this is different than when you locally served your app. Local apps and published apps you're subscribed to show under Your apps instead.

It looks to me like you can access subscriptions from Your apps and Instant Observability now, whereas when this was written, it was either in Your apps or New Relic One catalog, but not both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A paragraph further down the page says:

View your app in the catalog:

Are we ok with calling this "the catalog" or are we trying to move away from that terminology? Maybe we should update this:

View your app in Instant Observability:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toward the conclusion, this guide says:

Even though the app is ready for public use, it's still only visible to users of your account. Other accounts can't see apps created by other private accounts unless those apps are added to the public New Relic One catalog.

I think we want this to say:

...unless those apps are added to Instant Observability.

Similarly, the conclusion says:

Now that your app is published and its metadata is submitted, you can subscribe your account to the app from the catalog.

I think we want:

Now that your app is published and its metadata is submitted, you can subscribe your account to the app from Instant Observability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexronquillo These are great suggestions thank you! I'm curious what kind of place the term catalog still has in this experience, since we do have a Nerdpack artifact called catalog that is purposed around providing Nerdpack metadata for the "catalog".

https://developer.newrelic.com/build-apps/publish-deploy/catalog/

Is there a distinction to made here of "New Relic One catalog" as a named place in the UI that was replaced by "Instant Observability", but that Instant Observability has a "catalog" of resources in a non-proper name sense?

Would it be ok in some instances to say the Instant Observability catalog so that there is still some connection to this idea of a catalog and that aspect of a Nerdpack?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that there is a place for "catalog" as it applies to the registry of all published Nerdpacks, the Nerdpack artifact, and the command. I also agree with your distinction and that primarily what we want to change here are references to the New Relic One catalog in the UI.

I'll defer to @jpvajda about whether "Instant Observability catalog" is ok since I haven't really been part of those conversations and could go either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example

In the last lesson, you created catalog information for the A/B test app you've been building throughout this course. Now, it's time to publish your app to the New Relic One catalog and submit those catalog details.

Could be written as?:

In the last lesson, you created catalog information for the A/B test app you've been building throughout this course. Now, it's time to publish your app to the Instant Observability catalog and submit those catalog details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexronquillo Just pushed another pass on this updating the "New Relic One catalog" references to "Instant Observability"

I've also included in places references to "the Instant Observability catalog" to help connect catalog metadata to I/O. Happy to go back and edit those depending on how @jpvajda weighs in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through pretty closely and feel like these changes are really solid. Thanks again! Here's another example where "the Instant Observability catalog" feels like the right phrasing since it connects the CLI command / directories in the repo to their UI representation.

Screen Shot 2021-09-29 at 2 06 46 PM

@@ -21,9 +21,9 @@ In the last lesson, you published your A/B test app to the New Relic One catalog

## Subscribe to your application

Now that your application is published to the catalog, you can view it by visiting the **Apps** page of [New Relic](https://one.newrelic.com):
Now that your application is published to the catalog, you can view it by visiting the **Instant Observability** page of [New Relic](https://one.newrelic.com):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now that your application is published to the catalog, you can view it by visiting the **Instant Observability** page of [New Relic](https://one.newrelic.com):
Now that your application is published, you can view it by visiting the **Instant Observability** page of [New Relic](https://one.newrelic.com):

I'm wondering if "the catalog" is confusing, since it's not used with Instant Observability.


![Navigate to Apps](../../../images/build-an-app/nav-to-apps.png)
![Navigate to Instant Observability](../../../images/serve-publish-subscribe/nav-to-io.png)

From the catalog UI, you can subscribe to applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
From the catalog UI, you can subscribe to applications.
From Instant Observability, you can subscribe to applications.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further down, this guide mentions "the catalog" a lot. Should we update many (all) of these references as well?


</Step>

<Step>

Find your published Nerdpack under **New Relic One catalog**:
Find your published Nerdpack using the Apps filter or search bar:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Find your published Nerdpack using the Apps filter or search bar:
Find your published Nerdpack using the apps filter or search bar:

@MichelLosier MichelLosier dismissed stale reviews from mehreentahir16 and jaesius via d9601e4 September 29, 2021 18:01
@tyreer tyreer marked this pull request as ready for review September 29, 2021 19:02
Copy link
Contributor

@tyreer tyreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking real good, Michel! Thanks for all the detail-intensive effort here :D

@alexronquillo
Copy link
Contributor

Thanks @MichelLosier and @tyreer! 🚀

@alexronquillo alexronquillo merged commit f949138 into develop Sep 29, 2021
@alexronquillo alexronquillo deleted the mlosier/io-packdetails-refresh branch September 29, 2021 21:55
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.57.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants