Side nav style tweaks #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizBaker
added
enhancement
jerelmiller
reviewed
Jun 17, 2020
|
yes! that would be much smoother |
LizBaker
removed
the
work in progress
zstix
reviewed
Jun 18, 2020
| @@ -27,6 +27,11 @@ | |||
| align-items: center; | |||
| justify-content: space-between; | |||
| text-decoration: none; | |||
| transition: 0.1s; | |||
|
|
|||
| &:hover { | |||
There was a problem hiding this comment.
Could we maybe add something like this to prevent the hover state for the current page? Super nitpicky, but I think it we should try to communicate that clicking on the current page wont do anything of use.
Suggested change
| &:hover { | |
| &:not(.isCurrentPage):hover { |
There was a problem hiding this comment.
ah good idea, i'll make some minor tweaks in a new PR so we can get this in 🎉
zstix
approved these changes
Jun 18, 2020
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for minor style/functionality tweaks in the side nav
pending completion:
Related Issue(s) / Ticket(s)
Screenshot(s)