Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ru/featured filter #1608

Merged
merged 9 commits into from
Sep 14, 2021
Merged

Ru/featured filter #1608

merged 9 commits into from
Sep 14, 2021

Conversation

rudouglas
Copy link
Contributor

Screenshot 2021-09-10 at 15 53 28

Screenshot 2021-09-10 at 16 15 37

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 10, 2021 •
edited
Loading

Gatsby Cloud Build Report

developer-website-feature/o11y-packs

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

This was linked to issues Sep 10, 2021
[Public Catalog] Provide a featured filter for packs that are tagged as featured partner packs #1420
Closed
[Public Catalog] add labels to packs in the grid view #1561
Closed
jpvajda
jpvajda suggested changes Sep 10, 2021
View reviewed changes
jpvajda
jpvajda previously requested changes Sep 10, 2021
View reviewed changes
zstix
zstix previously requested changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@zstix zstix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of comments that we might want to address before merging this in.

aswanson-nr
aswanson-nr approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The featured filter cannot be deselected, but since we are making changes to that section in the coming sprint I think it's fine to merge as is.

@zstix zstix dismissed their stale review September 14, 2021 20:35

Changes incorporated

@aswanson-nr aswanson-nr dismissed jpvajda’s stale review September 14, 2021 21:01

Changes are incorporated

@aswanson-nr aswanson-nr merged commit 60a0f80 into feature/o11y-packs Sep 14, 2021
@aswanson-nr aswanson-nr deleted the ru/featured-filter branch September 14, 2021 21:01
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswanson-nr aswanson-nr aswanson-nr approved these changes

@jpvajda jpvajda jpvajda left review comments

@zstix zstix zstix left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
5 participants
@rudouglas @nr-opensource-bot @jpvajda @zstix @aswanson-nr