Fix logger API page
#1580
Merged
Fix logger API page
#1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's worth noting that, in most cases, this will always be present. This is mostly just a precaution for times when the SDK is not formatted in a way that our code expects. At the time of commit, the `logger` API documentation is returning `null` descriptions.
Gatsby Cloud Build Reportdeveloper-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
Co-authored-by: Kris Kenny <[email protected]>
zstix
force-pushed
the
zstix/fix-logger-doc
branch
from
cb5e319 to
053becf
Compare
moonlight-komorebi
approved these changes
Sep 2, 2021
|
🎉 This PR is included in version 1.52.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a few fixes to reduce the number of errors on the developer site. More specifically, this removes:
keyfor the<meta>tags coming from our SEO componentloggerAPI page (due to the SDK being in a weird state - see screenshots)Screenshot(s)
It looks like the SDK for the
loggerAPI is mostly incomplete. A number of the adjustments in the PR were defensive adjustments to get the page to render without errors. That said, it's still pretty incomplete: