Add link to repo pack directory #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* now on each pack page, there is a button with a link to the pack directory in the page section. * added github images copied from opensource repo.
Gatsby Cloud Build Reportdeveloper-website-feature/o11y-packs 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m |
5 tasks
zstix
suggested changes
Jul 8, 2021
There was a problem hiding this comment.
My requests on the PR preview branch are all going to a 404. Looks like the URL has some placeholder text in it: https://observabilitypacks-addlinktorepopackdirectory.gtsb.io/github.com/newrelic/newrelic-observability-packs/tree/main/packs/cassandra
Left a few other comments about code style.
Also, why was the lock file updated? 🤔
aswanson-nr
previously requested changes
Jul 8, 2021
* broke out the getPackUrl method into its own utility * import & call the utility from observabilityPackDetails
* there is already instrumentation used in the button component, just missing data for what we want to track. added packName as something we might want to track.
* swap back to using logoUrl to check * updated tests
zstix
approved these changes
Jul 8, 2021
|
🎉 This PR is included in version 1.57.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button to the pagetools section of a pack's page which, when clicked, takes the user to the packs main directory in the newrelic-observability-packs repo, or the packs/ directory for all packs (if the particular pack does not have a logo).
Resolves: #1447
Screenshots