Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed name to requirements #1419

Merged
merged 2 commits into from
Jun 23, 2021
+6 −4
Merged

chore: changed name to requirements #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c66a8e
chore: changed name to requirements
Jun 22, 2021
b224aed
update style guide
Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions STYLE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
- [GuideTemplate Frontmatter example](#guidetemplate-frontmatter-example)
- [Reusable components](#reusable-components)
- [Embed guides](#embed-guides)
- [Example](#example)
- [Hiding content on embedded pages](#hiding-content-on-embedded-pages)
- [Grammar and formatting](#grammar-and-formatting)
- [Format titles](#format-titles)
- [Format headers](#format-headers)
Expand Down Expand Up @@ -348,11 +350,11 @@ Each guide on the site (in frontmatter `template: GuideTemplate`) has an embed p

If there's a guide with this URL:

https://developer.newrelic.com/path/to/guide
https://developer.newrelic.com/path/to/guide

The embed page URL would be:

https://developer.newrelic.com/path/to/guide/embed
https://developer.newrelic.com/path/to/guide/embed

You can use the embed URL in an `<iframe src=EMBED_URL />` on another site to display guide content.

Expand Down
4 changes: 2 additions & 2 deletions src/templates/ObservabilityPackDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const ObservabilityPackDetails = ({ data, location }) => {
`}
>
<Tabs.BarItem id="overview">Overview</Tabs.BarItem>
<Tabs.BarItem id="dependencies">Dependencies</Tabs.BarItem>
<Tabs.BarItem id="requirements">Requirements</Tabs.BarItem>
<Tabs.BarItem
id="dashboards"
disabled={!(pack.dashboards?.length ?? 0)}
Expand Down Expand Up @@ -100,7 +100,7 @@ const ObservabilityPackDetails = ({ data, location }) => {
<h3>Description</h3>
<p>{pack.description}</p>
</Tabs.Page>
<Tabs.Page id="dependencies">
<Tabs.Page id="requirements">
<Intro
css={css`
margin-bottom: 16px;
Expand Down