Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make o11y pack landing more responsive #1378

Merged
merged 6 commits into from
Jun 8, 2021

Conversation

roadlittledawn
Copy link
Contributor

Description

Adds more responsive-ness to landing page, especially form controls / filters. Adds some custom form components for more control over styling and behavior. Very similar to those used in docs site's data dictionary page.

The grid view is already responsive.

Reviewer notes

  • we may want to further refactor how filters work with state and URL params. i noticed that if you load a page with query params, the defaults are applied, then state is updated from query params.

Related Issue(s) / Ticket(s)

Closes #1349

we may need to wait or merge the work for list view && adding logos for featured images

Screenshot(s)

2021-06-07_16-51-10

2021-06-07_16-51-02

@roadlittledawn roadlittledawn changed the title Clang/responsive landing Make o11y pack landing more responsive Jun 7, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 7, 2021

Gatsby Cloud Build Report

developer-website-feature/o11y-packs

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Copy link
Contributor

@zstix zstix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple minor comments.

@roadlittledawn roadlittledawn merged commit 409a703 into feature/o11y-packs Jun 8, 2021
@roadlittledawn roadlittledawn deleted the clang/responsive-landing branch June 8, 2021 21:49
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants