Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rewrite Nerdpack permissions to clarify #1319

Merged
merged 6 commits into from
May 20, 2021
Merged

Conversation

alexronquillo
Copy link
Contributor

Description

This doc is highly confusing for many users and Relics. This rewrite aims to address the confusing issues and clarify Nerdpack permissions as best as possible.

mmfred
mmfred previously approved these changes May 17, 2021
Copy link
Contributor

@mmfred mmfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for you.

@alexronquillo
Copy link
Contributor Author

@mmfred Thanks for the review! I've submitted some commits addressing your feedback!

@jaesius jaesius merged commit 9e36275 into develop May 20, 2021
@jaesius jaesius deleted the permissions-update branch May 20, 2021 15:23
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants