Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terrform-modules.mdx #1255

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Update terrform-modules.mdx #1255

merged 2 commits into from
Apr 15, 2021

Conversation

jduarteihm
Copy link
Contributor

Small fat-finger of the reference to the alert policy in the code example.
Cheers

Description

Small change to a code example

Reviewer Notes

If there are links or steps needed to test this work, add them here.

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

If relevant, add screenshots here.

Use Conventional Commits

Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.

Use chore

  • for minor changes / additions / corrections to content.
  • for minor changes / additions / corrections to images.
  • for minor non-functional changes / additions to github actions, github templates, package or config updates, etc
git commit -m "chore: adjusting config and content"

Use fix

  • for minor functional corrections to code.
git commit -m "fix: typo and prop error in the code of conduct"

Use feat

  • for major functional changes or additions to code.
git commit -m "feat(media): creating a video landing page"

Small fat-finger of the reference to the alert policy in the code example.
Cheers
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

explanation references "HostModules" on line 73. This should be "HostConditions".
@jpvajda
Copy link
Contributor

jpvajda commented Apr 14, 2021

@alexronquillo would you mind validating this is correct?

@jpvajda jpvajda added the help wanted Extra attention is needed label Apr 14, 2021
@jpvajda jpvajda requested a review from alexronquillo April 14, 2021 22:51
@jpvajda
Copy link
Contributor

jpvajda commented Apr 14, 2021

@jduarteihm thanks for the contribution! I am just going to have it validated by one of our content engineers for accuracy. If you have a moment we'd love if you'd sign the contributor CLA.. just the message above for where to do that.

@alexronquillo
Copy link
Contributor

@jpvajda This looks good to me. Feel free to merge after the CLA 👍

@jpvajda jpvajda merged commit c14e260 into newrelic:develop Apr 15, 2021
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.42.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants