Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants section #121

Merged
merged 7 commits into from
Jun 11, 2020
Merged

Add constants section #121

merged 7 commits into from
Jun 11, 2020

Conversation

caylahamann
Copy link
Contributor

@caylahamann caylahamann commented Jun 10, 2020

Description

Adding constants to API docs section

Reviewer Notes

The only API that seems to have it is the nerdlet api, but it shows up there!

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

Screen Shot 2020-06-10 at 6 27 24 PM

@caylahamann caylahamann added the enhancement New feature or request label Jun 11, 2020
Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WONDERFUL work. I had just a few minor comments for you.

@caylahamann caylahamann requested a review from jerelmiller June 11, 2020 16:02
@jerelmiller jerelmiller merged commit e41071f into master Jun 11, 2020
@jerelmiller jerelmiller deleted the cayla/constants branch June 11, 2020 16:20
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants