Header Component (initial responsive styles) #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizBaker
approved these changes
Apr 23, 2020
timglaser
reviewed
Apr 23, 2020
| transition: 0.18s; | ||
| } | ||
|
|
||
| &.HamburgerMenu__open { |
There was a problem hiding this comment.
Following suit naming conventions this would be .is-open as a state classname.
There was a problem hiding this comment.
Thank you. I was unsure how best to name this class. I'll update it in a PR shortly.
| nav.nav--main { | ||
| width: 100%; | ||
| height: auto; | ||
| &.Header--main__menuOpen nav { |
There was a problem hiding this comment.
Same here with the suit naming convention.
Comment on lines
+12
to
+13
| className={cx('HamburgerMenu', { HamburgerMenu__open: open })} | ||
| onClick={() => toggle()} |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First pass at adding the mobile styles for the header / navigation component.
We will want to revisit this once we have final designs and direction around animations.
Related Ticket(s)
Screenshot(s)