Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Tutorial how-to #1195

Merged
merged 1 commit into from
Mar 26, 2021
Merged

chore: Update Tutorial how-to #1195

merged 1 commit into from
Mar 26, 2021

Conversation

alexronquillo
Copy link
Contributor

Description

  • Minor language edits for Tutorial component guide
  • Add "Things to keep in mind" section

Reviewer Notes

One of these might be a bug, so let me know if I should create an issue for that.

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

If relevant, add screenshots here.

Use Conventional Commits

Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.

Use chore

  • for minor changes / additions / corrections to content.
  • for minor changes / additions / corrections to images.
  • for minor non-functional changes / additions to github actions, github templates, package or config updates, etc
git commit -m "chore: adjusting config and content"

Use fix

  • for minor functional corrections to code.
git commit -m "fix: typo and prop error in the code of conduct"

Use feat

  • for major functional changes or additions to code.
git commit -m "feat(media): creating a video landing page"

Copy link
Contributor

@caylahamann caylahamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making some edits! I'm not the best writer 😆

@alexronquillo
Copy link
Contributor Author

No, it's great! It just needed a few tweaks. That extra section included my findings from using the component.

@alexronquillo alexronquillo merged commit 13e7eef into develop Mar 26, 2021
@alexronquillo alexronquillo deleted the tutorial-updates branch March 26, 2021 16:19
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants