Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths to set-up-dev-env guide #1166

Closed
wants to merge 58 commits into from
Closed

Fix paths to set-up-dev-env guide #1166

wants to merge 58 commits into from

Conversation

LizBaker
Copy link
Contributor

@LizBaker LizBaker commented Mar 8, 2021

Description

Noticed the set up dev environment guide links weren't fully formed in a few spots
Also thinking we want to link to a different guide than is currently linked to in the nr1 cli guide (it links to the set up dev env guide for info on permissions. thinking we want the permissions guide)

Reviewer Notes

Check out the 404 when clicking the "Set up your dev environment" link
https://developer.newrelic.com/build-apps/build-hello-world-app
https://developer.newrelic.com/build-apps/add-time-picker-guide
https://developer.newrelic.com/build-apps/add-nerdgraphquery-guide

And the guide linked when clicking "Authentication and permissions"
https://developer.newrelic.com/explore-docs/nr1-cli

nr-opensource-bot and others added 30 commits February 3, 2021 00:58
jerelmiller and others added 26 commits February 24, 2021 10:07
@jerelmiller
Copy link
Contributor

@LizBaker FYI, looks like you branched from main, which caused all of those commits to show up for this PR. Would you mind branching from develop for future PRs? That should help clean up the commit history. Thanks!

@LizBaker
Copy link
Contributor Author

LizBaker commented Mar 8, 2021

closing because i branched off main

@LizBaker LizBaker closed this Mar 8, 2021
@jerelmiller jerelmiller deleted the fix-paths branch March 8, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants