chore(podcasts): Add The Relicans Launchies and Polyglot podcast embeds #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
reviewed
Mar 8, 2021
There was a problem hiding this comment.
Hey @aaronbassett! Thanks so much for this contribution! Awesome that we have so much happening at New Relic that we can show off.
I've added a few [nit] comment, which you can accept or reject. Feel free to use your best judgement on whether you'd like to address this or not!
- Add meaningful title to iframes - Remove superfluous div from embed code - Move emebed map inline
|
Thanks for the review @jerelmiller, good catches! I've made the requested changes |
jerelmiller
approved these changes
Mar 8, 2021
|
🎉 This PR is included in version 1.35.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Buzzsprout embeds for the other Relicans Podcasts
Reviewer Notes
On the Podcasts page there should now be 3 embeds. Two listed above and the original Observy McObserveface
Screenshot(s)