Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 17 #1160

Merged
merged 6 commits into from
Mar 6, 2021
Merged

Upgrade to React 17 #1160

merged 6 commits into from
Mar 6, 2021

Conversation

jerelmiller
Copy link
Contributor

Description

Upgrades the site to React 17. This is the first step to getting to Gatsby v3.

Copy link
Contributor

@caylahamann caylahamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just posed a question for my own edification. I also assume that we are first going to make these changes on the developer site before applying it the docs site as a whole?

@@ -37,8 +37,8 @@
"prism-react-renderer": "^1.1.1",
"prismjs": "^1.21.0",
"prop-types": "^15.7.2",
"react": "^16.12.0",
"react-dom": "^16.12.0",
"react": "^17.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any concerns with us upgrading to react 17?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be! Check out the preview! https://pr-1160.dlyi50rq9kt6c.amplifyapp.com/

Its fully backwards compatible, so as far as I'm aware, nothing should break as a result of the upgrade.

@jerelmiller jerelmiller merged commit 4858d38 into develop Mar 6, 2021
@jerelmiller jerelmiller deleted the jerel/react-17 branch March 6, 2021 06:14
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.35.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants