-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React 17 #1160
Upgrade to React 17 #1160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Just posed a question for my own edification. I also assume that we are first going to make these changes on the developer site before applying it the docs site as a whole?
@@ -37,8 +37,8 @@ | |||
"prism-react-renderer": "^1.1.1", | |||
"prismjs": "^1.21.0", | |||
"prop-types": "^15.7.2", | |||
"react": "^16.12.0", | |||
"react-dom": "^16.12.0", | |||
"react": "^17.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any concerns with us upgrading to react 17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be! Check out the preview! https://pr-1160.dlyi50rq9kt6c.amplifyapp.com/
Its fully backwards compatible, so as far as I'm aware, nothing should break as a result of the upgrade.
🎉 This PR is included in version 1.35.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Upgrades the site to React 17. This is the first step to getting to Gatsby v3.