Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on the Builder's page #1099

Merged
merged 8 commits into from
Feb 5, 2021
Merged

Fixes on the Builder's page #1099

merged 8 commits into from
Feb 5, 2021

Conversation

pachicodes
Copy link
Contributor

Description

I Fixed some spelling errors and image sizing on the Builders page .

Reviewer Notes

If there are links or steps needed to test this work, add them here.

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

Screenshot(s)

If relevant, add screenshots here.

Use Conventional Commits

Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.

Use chore

  • for minor changes / additions / corrections to content.
  • for minor changes / additions / corrections to images.
  • for minor non-functional changes / additions to github actions, github templates, package or config updates, etc
git commit -m "chore: adjusting config and content"

Use fix

  • for minor functional corrections to code.
git commit -m "fix: typo and prop error in the code of conduct"

Use feat

  • for major functional changes or additions to code.
git commit -m "feat(media): creating a video landing page"

Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pachicodes, thanks for submitting this PR!

I noticed a package-lock.json file was commited. We use yarn for this repo. Can you remove that file? Thanks!

@pachicodes
Copy link
Contributor Author

I believe I have fixed all the requested issued. Thank you for your patience with me, I am new to Open Source and really appreciate it!☺️

Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks so much for getting that updated!!

And you're very welcome 😄. I was new to open source last year when we started the new dev site, so I know how it goes! Its definitely a journey, but a super fun space to work in. Thanks again for submitting this PR!

@jerelmiller jerelmiller merged commit 21d7c62 into newrelic:develop Feb 5, 2021
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.35.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants