-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes on the Builder's page #1099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pachicodes, thanks for submitting this PR!
I noticed a package-lock.json
file was commited. We use yarn
for this repo. Can you remove that file? Thanks!
I believe I have fixed all the requested issued. Thank you for your patience with me, I am new to Open Source and really appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Thanks so much for getting that updated!!
And you're very welcome 😄. I was new to open source last year when we started the new dev site, so I know how it goes! Its definitely a journey, but a super fun space to work in. Thanks again for submitting this PR!
🎉 This PR is included in version 1.35.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
I Fixed some spelling errors and image sizing on the Builders page .
Reviewer Notes
If there are links or steps needed to test this work, add them here.
Related Issue(s) / Ticket(s)
If there are any related GitHub Issues or JIRA tickets, add links to them here.
Screenshot(s)
If relevant, add screenshots here.
Use Conventional Commits
Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.
Use
chore
git commit -m "chore: adjusting config and content"
Use
fix
git commit -m "fix: typo and prop error in the code of conduct"
Use
feat
git commit -m "feat(media): creating a video landing page"