Generate component documentation from GraphQL instead of runtime #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage, and examples from graphql
…transformer-sharp
jerelmiller
commented
Jan 28, 2021
| @@ -179,4 +256,211 @@ PropList.propTypes = { | |||
| ), | |||
| }; | |||
|
|
|||
| export const query = graphql` | |||
| fragment PropList_propTypes on NewRelicSdkPropTypeDefinition { | |||
There was a problem hiding this comment.
Don't ask. This query was so hard 😂
There was a problem hiding this comment.
I remember trying to write prop types for the prop prop types and getting so turned around 😵
zstix
approved these changes
Jan 28, 2021
|
You're welcome! This was fun :) |
|
🎉 This PR is included in version 1.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1077
Description
Generates the New Relic One SDK documentation from the data in GraphQL rather than at runtime. This should help out our SEO tremendously for those pages. This PR also auto generates pages for each component/api in the SDK so that we no longer have to manually create MDX files for each component.
Screenshots
Before
After