fix: Balances the visual design of the props section #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
reviewed
Jun 8, 2020
| width: 70%; | ||
|
|
||
| p:first-of-type { |
There was a problem hiding this comment.
FYI, I did address this in #105 by adding a markdownContainer class. Since there is more than 1 area that renders markdown in props, I figured that class might be of help.
It shouldn't break this styles, but just wanted to let you know it was there and would duplicate the style override. Up to you if you want to remove it or not.
|
Actually, it looks like this is all addressed in #105 😂, including the h3 spacing. Care if I close this? |
|
@jerelmiller Haha, go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor style tweaks to make the props section feel more balanced visually, including vertical alignment and font size of the details section.
Screenshot(s)
Before
After