Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase font size for component description in reference docs #104

Merged

Conversation

djsauble
Copy link
Contributor

@djsauble djsauble commented Jun 8, 2020

Description

Takes the Intro module styling and uses it for the component description in the reference docs.

Screenshot(s)

Before

Screen Shot 2020-06-09 at 11 08 38 AM

After

Screen Shot 2020-06-09 at 11 08 57 AM

@djsauble djsauble requested review from zstix and LizBaker June 8, 2020 22:18
Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I look at the preview, it looks like any descriptions with bullet points don't have the proper text styles. You'll see in this screenshot for the Button component that the bullets have black text with a different font-size. Is that something you want to address in this PR?

Screen Shot 2020-06-08 at 4 08 29 PM

@jerelmiller
Copy link
Contributor

I'm not sure why the check didn't complete, but it looks like the PR build did succeed. Link is here: https://pr-104.dlyi50rq9kt6c.amplifyapp.com

@djsauble
Copy link
Contributor Author

djsauble commented Jun 8, 2020

@jerelmiller Looks like this is because the description can contain tags other than <p> (e.g. <ul>).

Should I try to enumerate all the different sorts of tags that can appear here, or just use a wildcard selector?

:global {
  .intro-text {
    * {
      color: var(--color-neutrals-600);
      font-size: 1.125rem;
      line-height: 2rem;
    }
  }
}

@jerelmiller
Copy link
Contributor

jerelmiller commented Jun 8, 2020

Rather than targeting the p tag inside, is there anything preventing us from just targeting the container itself with these styles?

:global {
  .intro-text {
      color: var(--color-neutrals-600);
      font-size: 1.125rem;
      line-height: 2rem;
  }
}

@djsauble
Copy link
Contributor Author

djsauble commented Jun 8, 2020

@jerelmiller I tried that, but we're defining styles on the <p> and <ul> tags directly (in styles.scss) which overrides any styles we might set on the parent element.

Maybe we can pair on this tomorrow if you have time.

@djsauble djsauble requested a review from jerelmiller June 9, 2020 18:18
jerelmiller
jerelmiller previously approved these changes Jun 9, 2020
@jerelmiller jerelmiller merged commit 116c2b3 into master Jun 9, 2020
@jerelmiller jerelmiller deleted the increase_font_size_for_intro_paragraph_in_reference_docs branch June 9, 2020 21:02
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants