-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Public Catalog] external links in the quickstarts markdown should be highlighted with the external link icon #1751
Comments
Approach idea: Look into parsing for links, then replacing them with the link component. Look into how the docs site parses and displays links. - @aswanson-nr |
The ReactMarkdown library, which we are using, allows you to specify react components that replace the normal HTML. So we can specify a custom React component for the |
Just waiting for the theme to be updated until this can be done |
…_quickstart_markdown chore: show icon for links in markdown quickstart descriptions (#1751)
🎉 This issue has been resolved in version 1.67.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Here's the design research on this: https://www.figma.com/file/0jsTPLtwz6Bljndkbr1COn/?node-id=339%3A9078 TLTR:
|
Thanks @legnaleama I like
For merging them, you could argue that
|
@roadlittledawn may have thoughts on this as well. 👋 |
When external links are used in quickstart descriptions we should be highlighted those links with the external link icon so the user knows they'll be taking out of the New Relic experience.
Design Questions
will be confirmed at our next design <> deven sync, but it's assume this is an OK approach
Acceptance Criteria
DevEx
to see if they also want to take the same approach in the product.Screenshot
The text was updated successfully, but these errors were encountered: