fix: escape works now and fixed minor things

newrelic · Jun 25, 2020 · eebf794 · eebf794
1 parent de40df6
commit eebf794
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/components/FeatherIcon.js b/src/components/FeatherIcon.js
@@ -18,7 +18,7 @@ const FeatherIcon = ({ className, name, size = '1em' }) => {
   ) : null;
 };
 
-// Icons from
+// Icons from https://feathericons.com/
 const ICONS = {
   'book-open': (
     <>

diff --git a/src/components/SearchInput.js b/src/components/SearchInput.js
@@ -14,19 +14,22 @@ const SearchInput = ({ className, onClear, value, ...props }) => {
   };
   return (
     <div className={cx(styles.container, className)}>
-      <input value={value} {...props} className={styles.input} type="text" />
-      <span
+      <input
+        value={value}
+        {...props}
+        className={styles.input}
+        type="text"
+        onKeyDown={handleKeyDown}
+      />
+      <div
         role="button"
         tabIndex={0}
-        onKeyDown={handleKeyDown}
         onClick={handleClick}
         className={styles.clearButton}
+        onKeyDown={(e) => e.preventDefault()}
       >
-        <FeatherIcon
-          name={value !== '' ? 'x' : 'search'}
-          className={styles.icon}
-        />
-      </span>
+        <FeatherIcon name={value ? 'x' : 'search'} className={styles.icon} />
+      </div>
     </div>
   );
 };