feat: render a comma between multiple args to func definition

newrelic · Jun 7, 2020 · 918d6e0 · 918d6e0
1 parent 9dd5137
commit 918d6e0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/components/FunctionDefinition.js b/src/components/FunctionDefinition.js
@@ -27,8 +27,8 @@ const FunctionDefinition = ({ params, returnValue }) => {
       </span>
       {params.map((param, i) => (
         <div key={i} className={styles.param}>
-          <span className={styles.paramName}>{param.name}: </span>
-          <span className={styles.type}>{param.type} </span>
+          {param.name}: <span className={styles.type}>{param.type} </span>
+          {i !== params.length - 1 && ','}
           <Markdown
             source={param.description}
             renderers={{

diff --git a/src/components/FunctionDefinition.module.scss b/src/components/FunctionDefinition.module.scss
@@ -9,11 +9,8 @@
 }
 
 .param {
-  margin-left: 1rem;
-}
-
-.paramName {
   color: var(--color-neutrals-700);
+  margin-left: 1rem;
 }
 
 .paramDescription {

diff --git a/src/utils/propTypeInfo.js b/src/utils/propTypeInfo.js
@@ -98,8 +98,8 @@ export const getTypeMeta = (name, propType, { component }) => {
   switch (getRawTypeName(propType)) {
     case 'func':
       return {
-        returnValue: propTypeDocs.tags?.returnValue ?? { type: 'undefined' },
-        params: propTypeDocs.tags?.param ?? [],
+        returnValue: propTypeDocs?.tags?.returnValue ?? { type: 'undefined' },
+        params: propTypeDocs?.tags?.param ?? [],
       };
     case 'shape': {
       const [shape] = getArgs(propType);