chore: Pull list of components from constants inside plugin instead o…

…f config
newrelic · Jun 28, 2020 · 541f9bd · 541f9bd
1 parent 05af37c
commit 541f9bd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/gatsby-config.js b/gatsby-config.js
@@ -76,8 +76,6 @@ module.exports = {
       resolve: 'gatsby-source-newrelic-sdk',
       options: {
         release: 'release-1093',
-        components: ['Button', 'BlockText'],
-        apis: ['logger', 'nerdlet'],
       },
     },
     'gatsby-plugin-meta-redirect',

diff --git a/plugins/gatsby-source-newrelic-sdk/gatsby-node.js b/plugins/gatsby-source-newrelic-sdk/gatsby-node.js
@@ -1,5 +1,6 @@
 const loadSdk = require('./src/loadSdk');
 const { getComponentDoc, getApiDoc } = require('./src/docInfo');
+const { DOCUMENTED_APIS, DOCUMENTED_COMPONENTS } = require('./src/constants');
 
 const hasOwnProperty = (obj, name) =>
   Object.prototype.hasOwnProperty.call(obj, name);
@@ -106,12 +107,12 @@ exports.createResolvers = ({ createResolvers }) => {
 
 exports.sourceNodes = async (
   { actions, createNodeId, createContentDigest },
-  { release, components = [], apis = [] }
+  { release }
 ) => {
   const { createNode } = actions;
   const sdk = await loadSdk(release);
 
-  components.forEach((name) => {
+  DOCUMENTED_COMPONENTS.forEach((name) => {
     const data = getComponentDoc(name, sdk);
 
     if (data) {
@@ -128,7 +129,7 @@ exports.sourceNodes = async (
     }
   });
 
-  apis.forEach((name) => {
+  DOCUMENTED_APIS.forEach((name) => {
     const data = getApiDoc(name, sdk);
 
     if (data) {

diff --git a/plugins/gatsby-source-newrelic-sdk/src/constants.js b/plugins/gatsby-source-newrelic-sdk/src/constants.js
@@ -0,0 +1,2 @@
+module.exports.DOCUMENTED_APIS = ['logger', 'nerdlet'];
+module.exports.DOCUMENTED_COMPONENTS = ['AccountPicker', 'Button'];
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		module.exports.DOCUMENTED_APIS = ['logger', 'nerdlet'];
		module.exports.DOCUMENTED_COMPONENTS = ['AccountPicker', 'Button'];