Skip to content

Update requirements to minimal necessary - #55

Open
timothybonci wants to merge 1 commit into
newrelic:masterfrom
timothybonci:requirements
Open

Update requirements to minimal necessary#55
timothybonci wants to merge 1 commit into
newrelic:masterfrom
timothybonci:requirements

Conversation

@timothybonci

Copy link
Copy Markdown

Currently, we maintain a list (outdated) specifying dependencies of our dependencies, and there's no reason to take on that burden. (See previous MRs bumping versions of requirements that we don't directly use). If we strip this down to only what we use and allow those things to specify their own requirements, the system works great.

This also reduces the imports to minimal for keeping bundles small.

This should be entirely nonfunctional and mostly philosophical. Running this install (a couple days ago) produced the following plan:

Would install

  • aiohttp-3.8.4
  • aiosignal-1.3.1
  • async-timeout-4.0.2
  • attrs-23.1.0
  • boto3-1.24.59
  • botocore-1.27.96
  • charset-normalizer-3.1.0
  • frozenlist-1.3.3
  • idna-3.4
  • jmespath-1.0.1
  • multidict-6.0.4
  • python-dateutil-2.8.1
  • s3transfer-0.6.1
  • six-1.16.0
  • smart-open-6.3.0
  • urllib3-1.26.16
  • yarl-1.9.2

I've also installed this version of the lambda into my production environment and it's working.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@timothybonci

Copy link
Copy Markdown
Author

CLA is under review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants