Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete of stack should delete filters as well #14

Merged
merged 3 commits into from
Dec 6, 2024
Merged

delete of stack should delete filters as well #14

merged 3 commits into from
Dec 6, 2024

Conversation

hrai-nr
Copy link
Contributor

@hrai-nr hrai-nr commented Dec 4, 2024

After this code changes:

On stack deletion, we will delete any subscription filter created on any log group created as part of this particular stack

Testing:

  1. Create a stack with selecting log group name, see that a subscription filter is created. Delete the stack, the subscription filter should be deleted.
  2. Take a log group with existing subscription filter already present. Create a cloud formation stack with this particular stack, see that second subscription filter get created. Now delete this stack, only the second subscription filter should be deleted. The subscription filter created prior to our stack creation should not get deleted.

@hrai-nr hrai-nr merged commit 488eeaf into main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants