New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firehose minor bug fixes #12

Merged

hrai-nr merged 2 commits into main from NR-343406

Nov 25, 2024

Contributor

hrai-nr commented Nov 25, 2024

This PR will fix these 2 bugs:

Secret manager permission is missing for the delivery stream
If we don’t pass CommonAttribute or LogGroup config the validation is failing. It should not be checked.


          bug fixes for firehose

cfcc2e3

maya-jha reviewed

View reviewed changes

firehose-template.yaml Outdated Show resolved Hide resolved


          code based on review comment

b9eced9

maya-jha approved these changes

View reviewed changes

hrai-nr merged commit fef7039 into main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet