Make parent trace names consistent between runs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With tracing in newrelic, groups are done via the name on the parent trace. With each run having a unique name (due to the run ID being unique each time), it makes it hard to use the traces and compare runs over time. If the previous functionality is desired by consumers of this action, it is easy enough to restore by updating the GHA_RUN_NAME environment variable, which is only used in the context of the name of the parent trace.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With tracing in newrelic, groups are done via the name on the parent trace. With each run having a unique name (due to the run ID being unique each time), it makes it hard to use the traces and compare runs over time. If the previous functionality is desired by consumers of this action, it is easy enough to restore by updating the GHA_RUN_NAME environment variable, which is only used in the context of the name of the parent trace.
The top group of traces were collected by github.com/inception-health/otel-export-trace-action and feature very similar results. This change is necessary for us to replace that action with this one. (note the difference in the service name, which this action achieves better by naming it after the repo)