Chore: upstream v0.47.6 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bryan White <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…s#17632) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]>
…7671) Co-authored-by: Cal Bera <[email protected]>
…#17668) (cosmos#17675) Co-authored-by: Bala Murali Krishna Komatireddy <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…mos#17780) (cosmos#17793) Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…s#17769) (cosmos#17848) Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
…17887) Co-authored-by: samricotta <[email protected]>
) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Marko <[email protected]>
cosmos#17910) (cosmos#17916) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…os#18012) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Devon Bear <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: shuoer86 <[email protected]>
…mos#18069) Co-authored-by: Marko <[email protected]>
Co-authored-by: Marko <[email protected]>
….12.4 (cosmos#18136) Co-authored-by: Julien Robert <[email protected]>
…n standalone mode (v0.47) (cosmos#18109) Co-authored-by: Marko <[email protected]>
…osmos#18208) Co-authored-by: Marko <[email protected]>
…#18218) Co-authored-by: Marko <[email protected]>
…sk (backport cosmos#18210) (cosmos#18230) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…smos#18249) (cosmos#18251) Co-authored-by: Julien Robert <[email protected]>
…BlockBitmap to keep compatibility for third-party projects
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -501,7 +501,7 @@ | |||
| func GetSnapshotStore(appOpts types.AppOptions) (*snapshots.Store, error) { | |||
| homeDir := cast.ToString(appOpts.Get(flags.FlagHome)) | |||
| snapshotDir := filepath.Join(homeDir, "data", "snapshots") | |||
| if err := os.MkdirAll(snapshotDir, os.ModePerm); err != nil { | |||
| if err := os.MkdirAll(snapshotDir, 0o744); err != nil { | |||
Check failure
Code scanning / Golang security checks by gosec
Expect directory permissions to be 0750 or less Error
| @@ -223,7 +223,9 @@ | |||
| // Implements types.KVStore. | |||
| func (st *Store) Delete(key []byte) { | |||
| defer telemetry.MeasureSince(time.Now(), "store", "iavl", "delete") | |||
| st.tree.Remove(key) | |||
| if _, _, err := st.tree.Remove(key); err != nil { | |||
| panic(err) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| @@ -144,6 +144,8 @@ | |||
| // onWrite writes a KVStore operation to all of the WriteListeners | |||
| func (s *Store) onWrite(delete bool, key, value []byte) { | |||
| for _, l := range s.listeners { | |||
| l.OnWrite(s.parentStoreKey, key, value, delete) | |||
| if err := l.OnWrite(s.parentStoreKey, key, value, delete); err != nil { | |||
| panic(err) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| @@ -195,5 +195,7 @@ | |||
| panic(errors.Wrap(err, "failed to write trace operation")) | |||
| } | |||
|
|
|||
| io.WriteString(w, "\n") | |||
| if _, err = io.WriteString(w, "\n"); err != nil { | |||
| panic(errors.Wrap(err, "failed to write newline")) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| @@ -42,6 +44,10 @@ | |||
| } | |||
|
|
|||
| func (msg MsgUpdateParams) ToProtoConsensusParams() tmproto.ConsensusParams { | |||
| if msg.Evidence == nil || msg.Block == nil || msg.Validator == nil { | |||
| panic(errors.New("all parameters must be present")) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.