Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log stream size not only length and connection count #64

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

metalefty
Copy link
Member

I believe it makes it easier to debug buffer overrun #9, #62.

Copy link
Contributor

@proski proski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is misleading; the connection count is still logged.

LLOGLN(0, ("rdpClientConSendMsg: overrun error len %d count %d",
len, clientCon->count));
LLOGLN(0, ("rdpClientConSendMsg: overrun error len %d "
"stream size %d client count %d",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add commas after the first and the second %d

it makes it easier to debug buffer overrun.
@metalefty metalefty changed the title log stream size rather than connection count log stream size not only length and connection count Jan 30, 2017
@metalefty
Copy link
Member Author

Let's merge this and keep our eyes on buffer overrun issue.

@jsorg71 jsorg71 merged commit 045c6fa into neutrinolabs:devel Jan 30, 2017
@metalefty metalefty deleted the misc branch August 20, 2020 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants