Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify a raw 40ms timer #339

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Constify a raw 40ms timer #339

merged 2 commits into from
Aug 28, 2024

Conversation

metalefty
Copy link
Member

Probably it is missed in d9850d1 #166.

@metalefty metalefty marked this pull request as draft August 21, 2024 14:08
@metalefty metalefty marked this pull request as ready for review August 22, 2024 14:06
@metalefty
Copy link
Member Author

@Nexarian The usage of UPDATE_RETRY_TIMEOUT is disappeared. Is this intended or is the code still needed?

b90dd28

@metalefty
Copy link
Member Author

The code is removed at b93ad93

@matt335672
Copy link
Member

Looks like a good idea to do this. I'm happy with it if Nex is.

@metalefty
Copy link
Member Author

If the code is intendedly removed, I'll remove unused UPDATE_RETRY_TIMEOUT.

@metalefty
Copy link
Member Author

It is removed at #274 so ping to @jsorg71, too.

@metalefty
Copy link
Member Author

Anyway, UPDATE_RETRY_TIMEOUT is not in use at the moment, removed.

@metalefty metalefty merged commit 6007dee into neutrinolabs:devel Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalefty @matt335672