V0.10 cherry picks #321
Merged
V0.10 cherry picks #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A call to rdpClientConProcessMsgClientRegionEx() from xrdp with the frame number set to MAX_INT acks all outstanding frames. This is useful when a decoder has been deleted for a resize. A second feature of this call is that it ensures the next frame sent is a key frame in progressive mode. This is fine for a single monitor system. On a multi-monitor system however, this logic for this breaks one of the assumptions made by rdpDeferredUpdateCallback() which is that only updates for a single monitor are sent at once. In extreme output situations, this can result in some corruption on a multi-monitor resize. This PR separates out the key frame request from the frame ACK, and moves it into the memory allocation logic. Following a memory allocation or re-allocation, a key frame will always need to be sent. (cherry picked from commit b728306)
|
Sorry - forgot to mark as draft. Will report back when I've done a module test. |
|
All looks good to me. Screen shot of xeyes running with a couple of glxgears. Resizing tested of main 2K monitor (secondary is 1366x768):-
I don't have a proper 4K monitor available. |
|
Thanks, I will test it on my physical 4k monitor. |
|
It works perfectly for me. BTW, was #319 commit cherry-picked with |
|
I'll redo the cherry-pick. It won't change the code. |
(cherry picked from commit a183714)
matt335672
force-pushed
the
v0_10_cherry_picks
branch
from
3cda806
to
9d6c9a6
Compare
metalefty
approved these changes
Jul 17, 2024
|
Wiki updated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #288 and #319 to v0.10
Draft for now - will do some quick testing.