Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to wyhash from CRC for capture tile diff #301

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

metalefty
Copy link
Member

This is a cut out of #167 and a effort to address #300, originally suggested by @trishume. Removed scroll detection for simplicity at the moment.

After switching to wyhash, CPU usage is reduced by 1/2 to 1/3. I think there is more room to reduce using other hash algorithm with hardware acceleration.

@metalefty metalefty marked this pull request as ready for review April 9, 2024 04:03
@metalefty
Copy link
Member Author

I tested both wyhash and xxhash64 with lazy color convert. See #300 for results. I'm inclined to use wyhash.

@jsorg71 @Nexarian @matt335672 Any thoughts about which hash algorithm to use?

@jsorg71
Copy link
Contributor

jsorg71 commented Apr 9, 2024

I'll agree meta, I feel like we vetted wyhash well. I'm not concerned about the author as this is not used for security.

@matt335672
Copy link
Member

I think you've done a great job looking at this @metalefty. Because wyhash has been tested already, that would be my preferred option. You've also shown that replacing this in the future is straightforward, if we need to.

@metalefty
Copy link
Member Author

Merging this.

@metalefty metalefty merged commit 90706b1 into neutrinolabs:v0.10 Apr 10, 2024
8 checks passed
metalefty added a commit that referenced this pull request Apr 15, 2024
@metalefty metalefty deleted the v0.10-wyhash branch April 23, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants