Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give group permission also to disconnect socket #177

Merged
merged 1 commit into from
Dec 19, 2020
Merged

give group permission also to disconnect socket #177

merged 1 commit into from
Dec 19, 2020

Conversation

metalefty
Copy link
Member

Missed in #110.

@metalefty
Copy link
Member Author

Fix mistake and force pushed.

matt335672
matt335672 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK as far as it goes. There's no configurability here though - you can't specify the group owner of the socket, or whether you want to allow this option at all.

@metalefty metalefty merged commit 56a36b2 into neutrinolabs:devel Dec 19, 2020
@metalefty metalefty deleted the socket-perms branch December 19, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt335672 matt335672 matt335672 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalefty @matt335672