chore(goose): bump pinned goose CLI to v1.43.0 - #160
Merged
Conversation
Picks up the DeepSeek/Kimi thinking-mode fix (aaif-goose/goose#10366): on multi-turn tool calls the agent now accumulates all prior thinking blocks, keeps RedactedThinking, and extracts reasoning from mixed thinking+text messages, so providers stop rejecting turns with "reasoning_content in thinking mode must be passed back" 400s. Contract surfaces the ACP bridge depends on were checked against the v1.41.0..v1.43.0 diff and are unchanged: the `--with-builtin` flag, GOOSE_PATH_ROOT, the `YYYYMMDD_<n>` session id format, the `_goose/unstable/session/update` usage_update payload with its accumulated token counters, `_meta.goose.toolCall.toolName`, and every GOOSE_*/OPENAI_* env var applyProviderEnv sets. Two behaviour changes worth knowing about: - Session usage totals are now derived as max(sessions.accumulated_*, SUM(usage_ledger)) and roll subagent sessions up into their parent, so accumulated counters grow to include delegated work that used to go unbilled. The added `message_usage` notification is ignored by the bridge, which only reads usage_update. - The developer shell tool falls back to DEFAULT_EXTENSION_TIMEOUT (300s) when a call omits timeout_secs; it used to run unbounded. Left at the upstream default. The session store migrates v15 -> v16 (adds the usage_ledger table and sessions.parent_session_id); both steps are additive, so a rollback to v1.41.0 still reads the schema. Verified in a linux/amd64 container: the pinned asset downloads and reports 1.43.0, `goose acp --help` still offers --with-builtin, and a real initialize + session/new handshake returns session id 20260721_1, loads the developer builtin, creates the store under GOOSE_PATH_ROOT, and emits _goose/unstable/session/update with accumulatedInputTokens / accumulatedOutputTokens. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JNkGCVRVYMSziXZFbCTG68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the goose CLI pinned in
agents/goose/Dockerfilefrom v1.41.0 to v1.43.0 (latest release, 2026-07-14).Why
Picks up block/goose#10366 — DeepSeek/Kimi thinking-mode turns lost their reasoning blocks across multi-turn tool calls, so providers rejected the follow-up request with
reasoning_content in thinking mode must be passed back400s. The fix accumulates all prior thinking, keepsRedactedThinking, extracts reasoning from mixed thinking+text messages, and dedupes signed blocks. It landed in v1.43.0 and nothing earlier (git tag --contains 1e03bbb56→v1.43.0only).Contract check
Everything the ACP bridge in
agents/goose/srcdepends on was diffed acrossv1.41.0..v1.43.0and is unchanged:goose acp --with-builtin developerflagGOOSE_PATH_ROOTper-session storeYYYYMMDD_<n>(thesessionDirCodecassumption)_goose/unstable/session/update→usage_updatewithaccumulatedInputTokens/accumulatedOutputTokens_meta.goose.toolCall.toolNameGOOSE_*/OPENAI_*env varapplyProviderEnvsetsBehaviour changes to know about
max(sessions.accumulated_*, SUM(usage_ledger))and rolled up recursively from subagent sessions into the parent. Monotonic — existing sessions don't reset — but delegated work that previously went unbilled now shows up in the counters. The newmessage_usagenotification is ignored by the bridge, which only readsusage_update.shellcall that omitstimeout_secsnow falls back toDEFAULT_EXTENSION_TIMEOUT(300s) instead of running unbounded. Left at the upstream default; override withGOOSE_DEFAULT_EXTENSION_TIMEOUTif it turns out to bite.usage_ledgertable andsessions.parent_session_id. Both steps are additive and a rollback to v1.41.0 still reads the schema (queries name columns explicitly).crates/goose-server(the goosed REST path) was removed upstream — we talk ACP, so no impact.Verification
In a
linux/amd64container built from the new pin:goose --version→1.43.0goose acp --helpstill offers--with-builtininitialize(with_meta.goose.customNotifications) +session/newhandshake returnsagentInfo.version: 1.43.0, session id20260721_1, loads thedeveloperbuiltin, createsdata/sessions/sessions.dbunderGOOSE_PATH_ROOT, and emits_goose/unstable/session/updatecarryingaccumulatedInputTokens/accumulatedOutputTokensNot verified locally: an actual thinking-model turn exercising the #10366 fix — that needs a DeepSeek/Kimi endpoint and will be checked on a canary workspace after rollout.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JNkGCVRVYMSziXZFbCTG68