A buch of changes (hot fixes) to ensure nipype 1.0 compatibility #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -485,7 +485,7 @@ def _configure_spm_using_mcr(spm_mcr, spm_dir, spm_version): | |||
| _logger.info('setting SPM MCR path to "{}" ' | |||
| 'and "use_mcr" to True'.format(spm_mcr)) | |||
| spm.SPMCommand.set_mlab_paths( | |||
| matlab_cmd='{} run script'.format(spm_mcr), use_mcr=True) | |||
| matlab_cmd='{} batch'.format(spm_mcr), use_mcr=True) | |||
There was a problem hiding this comment.
Good catch on this. They have deprecated using "run" from recent standalone versions for SPM12. More details on this can be found here https://github.com/spm/spm12/blob/master/spm_standalone.m
I am wandering whether this might again get into script running errors when users fall back to slightly older standalone versions ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes that are necessary for pypreprocess to work with nipype 1.0