feat: add custom transform functions for state persistence #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor persist.ts to improve code organization and readability. - Add support for transform functions to modify the state before storing and after retrieving from storage. - Implement inbound and outbound transformers to handle state transformations. - Handle errors thrown by transformers and log them to the console. - Use the transformed state when reconciling and persisting the store. - Update persistStoreMdw function to use the transformed state when saving to storage. - Add tests for persist transformers
neurosnap
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this refactored version, of PR #45 , I've addressed the feedback by simplifying the API, removing the dynamic setters (setInTransformer and setOutTransformer) to reduce complexity.
The current version still offers flexibility by allowing state transformations without requiring dynamic changes after creation.
If further simplifications are necessary, I'm happy to refactor.
Refactor Highlights: