Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dataset used for the demonstration hagai_toy reported an error #50

Open
Taoo777 opened this issue Mar 7, 2024 · 3 comments
Open

Comments

@Taoo777
Copy link

Taoo777 commented Mar 7, 2024

@skinnider @jordansquair @AlanTeoYueYang @neurorestore
Thanks to this useful tool, I have been able to use Libra smoothly before. I reinstalled Libra today due to R environmental reasons, but found an Error when I ran Libra:

Error  in 'group_by()' :
! Must group by variables found in `.data`.
✖ Column `cell_type` is not found. 

To check if this is a problem with my dataset, I ran run_de: DE = run_de(hagai_toy) with the Libra built-in dataset hagai_toy but still got the same error, suggesting that there might be a problem with Libra itself. I noticed that Libra has been updated recently. Could you please check if there are any bugs?

@AlanTeoYueYang
Copy link
Collaborator

Hi, we have identified and fixed the bug.

@Taoo777
Copy link
Author

Taoo777 commented Mar 14, 2024

@AlanTeoYueYang
Thank you very much for your quick reply! I am now able to use Libra normally.

As a small suggestion, I would like to know if it is possible to add gene expression level information, such as the baseMean of DESeq2 or others, to the final result of run_de. This is because I noticed that the most differentially expressed genes tend to have very low expression levels (not even visible on the UMAP plot), and in fact, we focus more on genes that have a certain expression level and are also differentially expressed. So I thought that if the final result could provide information about gene expression levels, it would help users filter out genes that are too low to be of interest to them. I would really appreciate it if you would consider this!

@Taoo777
Copy link
Author

Taoo777 commented Mar 14, 2024

I noticed that the Libra:::pseudobulk_de function do not clean up the results of the differential expression analysis, so I tried using this function: DE_test = Libra:::pseudobulk_de(expr,meta = meta), but I got the following error:
Error in map():
ℹ In index: 1.
Caused by error in expr0 %*% mm:
! non-conformable arguments

However, when I use run_de: DE = run_de(expr,meta = meta) with the same dataset, I can run it normally and get the correct results, I don't know what's wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants