Modernise underlying data structure for node voltages #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
force-pushed
the
olupton/data-structures
branch
from
22ac03b
to
bd73ecb
Compare
olupton
commented
Jul 26, 2022
olupton
commented
Jul 26, 2022
olupton
force-pushed
the
olupton/data-structures
branch
from
0606a9f
to
52c54e0
Compare
|
I'm delighted to see that nrn/test/datahandle/test.py is working without address sanitizer complaints! Compiling did require: to avoid issues with but I think you already resolved that in another PR. If not, let me know and I'll push this change to this PR. |
olupton
force-pushed
the
olupton/data-structures
branch
2 times, most recently
from
6e101bd
to
0f9f7fc
Compare
alexsavulescu
force-pushed
the
olupton/data-structures
branch
from
321815f
to
bf5e48c
Compare
olupton
force-pushed
the
olupton/data-structures
branch
5 times, most recently
from
dd0dae2
to
47194d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
+ Coverage 47.51% 47.85% +0.34%
==========================================
Files 528 541 +13
Lines 118852 119572 +720
==========================================
+ Hits 56468 57223 +755
+ Misses 62384 62349 -35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexsavulescu
force-pushed
the
olupton/data-structures
branch
12 times, most recently
from
94dc46f
to
8bc8860
Compare
olupton
force-pushed
the
olupton/data-structures
branch
from
9069acc
to
e30394b
Compare
olupton
added a commit
that referenced
this pull request
Oct 10, 2022
- STETransition et al. now use STL components. - Removal of #if 0 block in nrn_finitialize fixes formatting there. - table_check_ no longer uses Datum. - PyHocObject is consistently defined in only one place. - Exception messages are printed to stderr when they are caught. - example_nmodl tests are unpacked into different tests, Python versions are run (not just HOC). - "Test fast_imem calculation" tests now check status codes.
6 tasks
alexsavulescu
added a commit
that referenced
this pull request
Oct 21, 2022
* hoist and match several changes from #1929 in order to reduce its diff * hack _pval <-> pval for backward MDB compatibility
|
Closing this as it is included in #2027. |
olupton
pushed a commit
that referenced
this pull request
Nov 3, 2022
* hoist and match several changes from #1929 in order to reduce its diff * hack _pval <-> pval for backward MDB compatibility
alexsavulescu
added a commit
that referenced
this pull request
Nov 7, 2022
* add a wrapper around `Datum` * hoist and match several changes from #1929 in order to reduce its diff * hack _pval <-> pval for backward MDB compatibility * implement .get<T> Co-authored-by: Olli Lupton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at importing the ideas of https://github.com/neuronsimulator/data-structure-design into NEURON.
Very WIP, detailed review not advised.