Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable Data Augmentations #189

Merged
merged 38 commits into from
Jan 18, 2022

Conversation

Aakanksha-Rana
Copy link
Member

@Aakanksha-Rana Aakanksha-Rana commented Dec 10, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

The goal of this PR is to enable sequence of on-the-fly augmentation by giving multiple transforms as list for argument 'augment' . This is open to suggestions and modifications to make it better and robust for different transform functionalities available in spatial_transform, intensity_transform and volume.

Checklist

  • I have added tests to cover my changes
  • I have updated documentation (if necessary)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@satra
Copy link
Contributor

satra commented Dec 23, 2021

this seems like a breaking change. if the default boolean option is dropped, it should be scheduled for deprecation in a few cycles and this code should warn people that the boolean option will be removed in a future version. i suspect that this is not being caught by current tests, so we should add a test as well.

@Aakanksha-Rana
Copy link
Member Author

Yes @satra, I will add the test and tutorial ipynb in this PR.

@Aakanksha-Rana
Copy link
Member Author

Fixes #167

nobrainer/dataset.py Outdated Show resolved Hide resolved
satra and others added 4 commits January 12, 2022 10:34
@Aakanksha-Rana - please check these changes, and do make sure that the transforms are capable of understanding what to do with the y-value (if it's a scalar, if it's image with integer labels, etc.,.)
@Aakanksha-Rana
Copy link
Member Author

Aakanksha-Rana commented Jan 12, 2022

We need to change Transforms.py functions in same format as intensity/spatial transforms to be able to take scalar or non-scalar labels.

@satra
Copy link
Contributor

satra commented Jan 12, 2022

We need to change Transforms.py functions in same format as intensity/spatial transforms to be able to take scalar or non-scalar labels.

can this be done for this PR ?

@Aakanksha-Rana
Copy link
Member Author

Aakanksha-Rana commented Jan 12, 2022

We need to change Transforms.py functions in same format as intensity/spatial transforms to be able to take scalar or non-scalar labels.

can this be done for this PR ?

I will change the apply_random_transform in this PR @satra .

@Aakanksha-Rana Aakanksha-Rana merged commit ef9d3b4 into neuronets:master Jan 18, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants