Bug Fix: Remove ‘past’ dependency from fssd.py and test_density.py (#423) #428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423. Removed
past.utils.old_div
fromfssd.py
andtest_density.py
to eliminateModuleNotFoundError
in Python 3.9+. Replacedold_div
with/
, and adjustedsimulate_null_dist
infssd.py
to use integer division (//
) to fix aTypeError
in tests. Verified locally withpytest hyppo/kgof/tests/
—all 12 tests passed on Python 3.12.Changes:
fssd.py
: Removedfrom past.utils import old_div
, replaced 8old_div
instances with/
, fixedd = len(eigs) / J
tod = len(eigs) // J
.test_density.py
: Removedfrom past.utils import old_div
, replaced 2old_div
instances with/
.python -m pytest hyppo/kgof/tests/
shows 12/12 passed.