Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Remove ‘past’ dependency from fssd.py and test_density.py (#423) #428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manuelarceaguirre
Copy link

Fixes #423. Removed past.utils.old_div from fssd.py and test_density.py to eliminate ModuleNotFoundError in Python 3.9+. Replaced old_div with /, and adjusted simulate_null_dist in fssd.py to use integer division (//) to fix a TypeError in tests. Verified locally with pytest hyppo/kgof/tests/—all 12 tests passed on Python 3.12.

Changes:

  • fssd.py: Removed from past.utils import old_div, replaced 8 old_div instances with /, fixed d = len(eigs) / J to d = len(eigs) // J.
  • test_density.py: Removed from past.utils import old_div, replaced 2 old_div instances with /.
  • Tested: python -m pytest hyppo/kgof/tests/ shows 12/12 passed.

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for hyppo ready!

Name Link
🔨 Latest commit f86ba2e
🔍 Latest deploy log https://app.netlify.com/sites/hyppo/deploys/67c67011a06f3c0008da954a
😎 Deploy Preview https://deploy-preview-428--hyppo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sampan501
Copy link
Collaborator

Thank you for your contribution! Changes look good to me. Once the tests pass, I will merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find module past
2 participants