[WIP] Add: Acceptance length tests for speculators #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
force-pushed
the
add-acceptance-length-tests
branch
3 times, most recently
from
1f8b8e0 to
d425f1c
Compare
rahul-tuli
force-pushed
the
add-acceptance-length-tests
branch
2 times, most recently
from
977d295 to
2e12d39
Compare
…n validation Add parameterized pytest tests to detect acceptance length regressions in EAGLE3 speculative decoding. Tests run inference on MT-Bench dataset (80 prompts) and assert both mean and per-position acceptance lengths are within 2% tolerance of baseline. Models tested: - Llama-3.1-8B-Instruct (AL: 2.60) - Qwen3-8B (AL: 2.26) - GPT-OSS-20B (AL: 2.56) Signed-off-by: rahul-tuli <[email protected]>
Signed-off-by: rahul-tuli <[email protected]>
Signed-off-by: rahul-tuli <[email protected]>
Signed-off-by: rahul-tuli <[email protected]>
- Use VllmRunner context manager instead of direct LLM instantiation - Use monkeypatch.context() for proper env var scoping - Use AcceptanceMetrics TypedDict in return statement - Remove docstrings from TypedDict and dataclass definitions - Remove inline comments from constants - Remove prototyping skip condition (all configs have baselines) - Fix gpt-oss-20b expected position 2 value (0.3220 -> 0.3337) Signed-off-by: rahul-tuli <[email protected]>
Signed-off-by: rahul-tuli <[email protected]>
Signed-off-by: rahul-tuli <[email protected]>
rahul-tuli
force-pushed
the
add-acceptance-length-tests
branch
from
2e12d39 to
5db9a9a
Compare
Signed-off-by: rahul-tuli <[email protected]>
Signed-off-by: yisheng <[email protected]>
vllm-project#32603) Signed-off-by: linhaifeng <[email protected]>
Signed-off-by: whx-sjtu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parameterized pytest tests to detect acceptance length regressions in EAGLE3 speculative decoding. These tests ensure that new commits do not degrade speculative decoding performance.
Changes
tests/v1/spec_decode/test_acceptance_length.py: New test file with parameterized tests for EAGLE3 model pairsModels Tested
meta-llama/Llama-3.1-8B-InstructRedHatAI/Llama-3.1-8B-Instruct-speculator.eagle3Qwen/Qwen3-8BRedHatAI/Qwen3-8B-speculator.eagle3openai/gpt-oss-20bRedHatAI/gpt-oss-20b-speculator.eagle3Test Design
philschmid/mt-benchdataset (80 prompts)llm.get_metrics()Test Plan
EAGLE3_MODEL_CONFIGSwith baseline valuesCUDA_VISIBLE_DEVICES=3 pytest tests/v1/spec_decode/test_acceptance_length.py -v -sUsage