Skip to content
This repository was archived by the owner on Jun 4, 2025. It is now read-only.

Fix DataParallel validation forward signatures #47

Merged
bfineran merged 3 commits into from
May 27, 2022
Merged

Fix DataParallel validation forward signatures #47

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae2e2fe
Fix: DataParallel validation forward signatures
KSGulin May 25, 2022
0db0db3
Update: generalize forward_fn selection
KSGulin May 25, 2022
c1eb612
nit: space
KSGulin May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2435,11 +2435,12 @@ def evaluation_loop(

observed_num_examples = 0
# Main evaluation loop
module_forward_fn = model.module.forward if isinstance(model, nn.DataParallel) else model.forward
for step, inputs in enumerate(dataloader):
inputs = {
k: inputs[k]
k: inputs[k]
for k in inputs
if k in list(inspect.signature(model.forward).parameters.keys())
if k in list(inspect.signature(module_forward_fn).parameters.keys())
}

# Update the observed num examples
Expand Down