This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Generalize disabling batch size across engine interfaces #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
reviewed
Aug 7, 2023
Contributor
bfineran
left a comment
bfineran
left a comment
There was a problem hiding this comment.
code LGTM - can you add a PR description with motivation + test scope?
Member
Author
|
@bfineran thanks and sorry this isn't complete, I meant to save it as a draft PR. Code is functional for my original needs but I have a new test suite I'd like to setup |
mgoin
requested review from
a team,
dbogunowicz,
rgreenberg1 and
robertgshaw2-redhat
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes changes to allow for the disabling of batch size checks, using batch size during random input generation, and disabling the engine's default batch size override behavior so the user doesn't need to define
NM_BATCH_SIZE_OVERRIDEthemselvesIf a batch size of
Noneor less than 1 is provided, a warning is logged and NM_DISABLE_BATCH_OVERRIDE is set. This provides a mechanism to disable the batch size override throughout the engine.