This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
keep stacktrace when throws an exception #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I just found out that this will break catch block or Observable.Catch since the original |
|
I think it's done now. |
|
sorry for too late, nice integration. |
EarMaster
pushed a commit
to EarMaster/UniRx
that referenced
this pull request
Jun 12, 2019
keep stacktrace when throws an exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #247
throw ex;will lose stack trace from where the exception is newed.Instead, we can treat
exas anInnerExceptionbythrow new Exception(null, ex);to keep stack trace.I grepped the source with
grep 'throw [^n]'and made this PR.reference(Japanese): http://ufcpp.net/study/csharp/misc_stacktrace.html