Ve-direct driver #440
Ve-direct driver #440
Conversation
|
Sorry for failed CI, fixed now. |
| } | ||
|
|
||
| void upsdrv_shutdown(void) | ||
| { |
There was a problem hiding this comment.
Is there certainly no session teardown?
|
|
||
| /* list flags and values that you want to receive via -x */ | ||
| void upsdrv_makevartable(void) | ||
| { |
There was a problem hiding this comment.
Aren't there variables to set up or modify like the port, maybe baud speed (e.g. use a default 19200 but reserve ability to probe related units with other hardware abilities)?
|
|
||
| void upsdrv_help(void) | ||
| { | ||
| printf("Read The Fine Manual ('man 8 ve-direct')\n"); |
There was a problem hiding this comment.
Related to question on configurable -x flags - maybe a bit more is to be said here. Maybe at least the standard wall of text with -a, -D and other standard flags.
|
I would prefer that these commits be rebased/squashed rather than merged as-is. The individual commits do not stand on their own. https://github.com/networkupstools/nut/blob/master/docs/developers.txt#L327 |
drivers/ve-direct.c
Outdated
| break; | ||
| *end = '\0'; | ||
|
|
||
| snprintf(vn, sizeof(vn), "ve-direct.%s", v_name); |
There was a problem hiding this comment.
"ve-direct" is not a valid top-level NUT variable name. Please use the standard names defined, and discuss on nut-upsdev if you need anything not covered here: http://networkupstools.org/docs/developer-guide.chunked/apas01.html
|
|
||
| void upsdrv_initups(void) | ||
| { | ||
| #ifndef TESTING |
There was a problem hiding this comment.
The TESTING #define is not handled elsewhere in NUT, but if you include it, I would recommend adding a case to parse a few static text buffers. This will help other developers who might have to maintain the code later down the road.
jimklimov
added
the
needs-work
jimklimov
added
the
experimental-namespace
…ed during fightwarn (so might add regressions) without regard to versioning
… we check for third-party dependencies
…and consult drivers/Makefile.am for list names to require certain dependencies
…sx) drivers - do not default to require them everywhere
…platform-dependent package groups
Working release of Ve-direct driver for Victron Energy UPS/solar panels monitoring.