-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DiffSyncModel.diffsync field #258
Open
jamesharr
wants to merge
14
commits into
networktocode:next-2.0
Choose a base branch
from
jamesharr:256-remove-dsm-ds-field
base: next-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove DiffSyncModel.diffsync field #258
jamesharr
wants to merge
14
commits into
networktocode:next-2.0
from
jamesharr:256-remove-dsm-ds-field
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration to Pydantic v2
…fsync-class renames diffsync.DiffSync to diffsync.Adapter
- Remove DiffSyncModel.diffsync field - Add diffsync parameter to DiffSyncModel.create/update/delete This closes networktocode#256
jamesharr
requested review from
glennmatthews,
Kircheneer and
chadell
as code owners
November 20, 2023 16:11
jamesharr
force-pushed
the
256-remove-dsm-ds-field
branch
3 times, most recently
from
November 20, 2023 16:46
2c27297
to
4881307
Compare
jamesharr
force-pushed
the
256-remove-dsm-ds-field
branch
from
November 20, 2023 16:47
4881307
to
00151f0
Compare
jamesharr
force-pushed
the
256-remove-dsm-ds-field
branch
from
November 20, 2023 17:16
00151f0
to
2fed5f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft that would implement #256