Add toml to dev dependencies. The new GH setup only install dev dependencies #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
requested review from
glennmatthews,
pke11y and
scetron
as code owners
ubajze
reviewed
Oct 25, 2022
| @@ -71,6 +71,8 @@ jobs: | |||
| uses: "actions/checkout@v3" | |||
| - name: "Setup environment" | |||
| uses: "networktocode/gh-action-setup-poetry-environment@v4" | |||
| with: | |||
| poetry-install-options: "--with dev" | |||
There was a problem hiding this comment.
Why not leave the default value?
| @@ -97,6 +99,8 @@ jobs: | |||
| uses: "actions/checkout@v3" | |||
| - name: "Setup environment" | |||
| uses: "networktocode/gh-action-setup-poetry-environment@v4" | |||
| with: | |||
| poetry-install-options: "--with dev" | |||
| @@ -121,6 +125,7 @@ jobs: | |||
| uses: "networktocode/gh-action-setup-poetry-environment@v4" | |||
| with: | |||
| python-version: "${{ matrix.python-version }}" | |||
| poetry-install-options: "--with dev" | |||
There was a problem hiding this comment.
I need to install the library to test it, and the default only install the dev, same happened in mypy
glennmatthews
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/networktocode/gh-action-setup-poetry-environment/blob/main/action.yml#L8