fix: filtermechanisms chain element should work correctly when NSE/crossNSE registered with tcp url #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
changed the title
Signed-off-by: denis-tingajkin <[email protected]>
denis-tingaikin
force-pushed
the
fix_filter_mechanisms
branch
from
d2a79de
to
cff8667
Compare
denis-tingaikin
commented
Sep 23, 2020
| } | ||
|
|
||
| func (f *filterMechanismsServer) Request(ctx context.Context, request *networkservice.NetworkServiceRequest) (*networkservice.Connection, error) { | ||
| p, ok := peer.FromContext(ctx) | ||
| if ok { | ||
| if p.Addr.Network() == "unix" { |
There was a problem hiding this comment.
Note: endpoint/crossnse could pass tcp URL for its local nsmgr on registration
Signed-off-by: denis-tingajkin <[email protected]>
denis-tingaikin
changed the title
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 23, 2020
…k@master networkservicemesh/sdk#475 networkservicemesh/sdk PR link: networkservicemesh/sdk#475 networkservicemesh/sdk commit message: commit d21b6743422d22e1bccf118a3c80e01fa8732a8a Author: Denis Tingaikin <[email protected]> Date: Wed Sep 23 23:16:26 2020 +0700 fix: filtermechanisms chain element should work correctly when NSE/crossNSE registered with tcp url (#475) * fix filtermechanisms chain element Signed-off-by: denis-tingajkin <[email protected]> * fix linter issues Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 23, 2020
…k@master networkservicemesh/sdk#475 networkservicemesh/sdk PR link: networkservicemesh/sdk#475 networkservicemesh/sdk commit message: commit d21b6743422d22e1bccf118a3c80e01fa8732a8a Author: Denis Tingaikin <[email protected]> Date: Wed Sep 23 23:16:26 2020 +0700 fix: filtermechanisms chain element should work correctly when NSE/crossNSE registered with tcp url (#475) * fix filtermechanisms chain element Signed-off-by: denis-tingajkin <[email protected]> * fix linter issues Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 23, 2020
…k@master networkservicemesh/sdk#475 networkservicemesh/sdk PR link: networkservicemesh/sdk#475 networkservicemesh/sdk commit message: commit d21b6743422d22e1bccf118a3c80e01fa8732a8a Author: Denis Tingaikin <[email protected]> Date: Wed Sep 23 23:16:26 2020 +0700 fix: filtermechanisms chain element should work correctly when NSE/crossNSE registered with tcp url (#475) * fix filtermechanisms chain element Signed-off-by: denis-tingajkin <[email protected]> * fix linter issues Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 23, 2020
…k@master networkservicemesh/sdk#475 networkservicemesh/sdk PR link: networkservicemesh/sdk#475 networkservicemesh/sdk commit message: commit d21b6743422d22e1bccf118a3c80e01fa8732a8a Author: Denis Tingaikin <[email protected]> Date: Wed Sep 23 23:16:26 2020 +0700 fix: filtermechanisms chain element should work correctly when NSE/crossNSE registered with tcp url (#475) * fix filtermechanisms chain element Signed-off-by: denis-tingajkin <[email protected]> * fix linter issues Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Sep 23, 2020
…k@master networkservicemesh/sdk#475 networkservicemesh/sdk PR link: networkservicemesh/sdk#475 networkservicemesh/sdk commit message: commit d21b6743422d22e1bccf118a3c80e01fa8732a8a Author: Denis Tingaikin <[email protected]> Date: Wed Sep 23 23:16:26 2020 +0700 fix: filtermechanisms chain element should work correctly when NSE/crossNSE registered with tcp url (#475) * fix filtermechanisms chain element Signed-off-by: denis-tingajkin <[email protected]> * fix linter issues Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingajkin [email protected]
Motivation
#461